Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetASCIIResponseCode looks ahead too far [ESP32] #21

Open
xennex22 opened this issue May 2, 2022 · 0 comments
Open

GetASCIIResponseCode looks ahead too far [ESP32] #21

xennex22 opened this issue May 2, 2022 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@xennex22
Copy link

xennex22 commented May 2, 2022

GetASCIIResponseCode search all of the rx buffer for keywords like OK, ERROR etc.

If the data arrives line by line this is ok. If the data arrives all at once then GetASCIIResponseCode will generally find OK and then ignore the preceding data. I note that AT+GMR has special processing to cope with this.

The solution is for GetASCIIResponseCode (and its associated functions) to only search the buffer for one line when matching strings.

@jkrech jkrech added the bug Something isn't working label May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants