Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Competitive matches are mistagged. #1912

Open
lauriys opened this issue Jul 9, 2024 · 1 comment
Open

Competitive matches are mistagged. #1912

lauriys opened this issue Jul 9, 2024 · 1 comment

Comments

@lauriys
Copy link

lauriys commented Jul 9, 2024

Competitive Clash matches such as 15255796834 are marked as PvPQuickplay & ClashQuickplay instead of their Competitive counterparts, while Competitive Collision (15255712599) isn't marked as neither PvPQuickplay nor PvPCompetitive, only AllPvP & ZoneControl.

@mikechambers
Copy link

mikechambers commented Nov 11, 2024

This is still an issue. It looks like all competitive matches do not have the correct mode set.

For example:
https://stats.bungie.net/Platform/Destiny2/Stats/PostGameCarnageReport/15681561118/

            "mode": 89,
            "modes": [
                5,
                89
            ],

This was a competitive zone control match. Should include mode 69 (PVPCompetitive).

Here is an example of competitive clash:
https://stats.bungie.net/Platform/Destiny2/Stats/PostGameCarnageReport/15681468746/

Again, missing mode 69.

To summarize:

For competitive collision modes:

  • Need to add a DestinyActivityModeType for Collision
  • directory activity hash should be collision: 1295334613
  • PVPCompetitive (69) should be added to modes
  • mode should be set to the new Collision

For competitive clash:

  • Need an activity type for CompetitiveClash (there might be one as there are multiple clash activity entries)
  • set directory activity hash to clash (or competitive clash)
  • set mode to ClashCompetitive 72
  • Remove 70 and 71 from modes (quickplay and clash quickplay)
  • add PVPCompetitive (69) to modes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants