Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DestinyRecordTitleBlock titlesByGender incorrect type definition #1924

Open
CaptnBlubber opened this issue Oct 27, 2024 · 0 comments
Open

DestinyRecordTitleBlock titlesByGender incorrect type definition #1924

CaptnBlubber opened this issue Oct 27, 2024 · 0 comments

Comments

@CaptnBlubber
Copy link

Just wanted to bring to your attention that the declared type for the dictionary key as declared in the schema is incorrect:

"Destiny.Definitions.Records.DestinyRecordTitleBlock": {
        "type": "object",
        "properties": {
          "hasTitle": {
            "type": "boolean"
          },
          "titlesByGender": {
            "type": "object",
            "additionalProperties": {
              "type": "string"
            },
            "x-dictionary-key": {
              "type": "integer",
              "format": "int32",
              "x-enum-reference": {
                "$ref": "#/components/schemas/Destiny.DestinyGender"
              },
              "x-enum-is-bitmask": false
            }
          },

The schema hints that the Gender will be displayed as integer, however instead it is displayed as String:

Example is the Conqueror Record (hash: 3464275895)

...
"titleInfo": {
    "hasTitle": true,
    "titlesByGender": {
      "Male": "Conqueror",
      "Female": "Conqueror"
    },
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant