Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: configure browser per search #27

Open
sasvdw opened this issue Nov 7, 2024 · 3 comments
Open

Feature Request: configure browser per search #27

sasvdw opened this issue Nov 7, 2024 · 3 comments
Labels
enhancement New feature or request pr welcome

Comments

@sasvdw
Copy link

sasvdw commented Nov 7, 2024

I mentioned it in this comment over on the PowerToys repo: microsoft/PowerToys#3420 (comment)

In short, the ability to configure what browser needs to be used for a specific search would be great. I'd suggest something along the following if it's possible to detect what browsers are installed.

  "Google": {
    "Url": "https://www.google.com/search?q=%s",
    "SuggestionProvider": "Google",
    "Browser": "Chrome"
  },
  "Bing": {
    "Url": "https://www.bing.com/search?q=%s",
    "SuggestionProvider": "Bing",
    "Browser": "MSEdge"
  },
  "GitHub": {
    "Url": "https://www.github.com/search?q=%s",
    "Keyword": "gh"
  },

In the example above GitHub would use the system's default browser, but Google and Bing would use Chrome and MS Edge respectively.

Alternatively, something like this can work for cases where a browser either isn't recognised or the ability to detect installed browsers doesn't exist:

  "Google": {
    "Url": "https://www.google.com/search?q=%s",
    "SuggestionProvider": "Google",
    "BrowserPath": "C:\Program Files\Google\Chrome\Application\chrome.exe"
  },

Best case, you could do both :)

@Daydreamer-riri
Copy link
Owner

Hi @sasvdw, I made some simple modifications, and the current version 0.6.3 supports the BrowserPath feature you mentioned. After testing, this feature works for both Chrome and Edge. However, since I am not a skilled .NET developer, I found that it does not work on Firefox. Nonetheless, I hope this can temporarily meet your needs.

@sasvdw
Copy link
Author

sasvdw commented Nov 11, 2024

This works perfectly! Luckily my chosen browsers are Chrome and Firefox, so this is a perfect stopgap!

@Daydreamer-riri
Copy link
Owner

Currently, I do not have the ability or willingness to further complete this feature.

I will keep this issue open and would welcome anyone who can contribute to this feature.
PR welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request pr welcome
Projects
None yet
Development

No branches or pull requests

2 participants