Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Signaling NaNs / Arithmetic Errors #731

Open
ax3l opened this issue Oct 9, 2024 · 1 comment
Open

Signaling NaNs / Arithmetic Errors #731

ax3l opened this issue Oct 9, 2024 · 1 comment
Labels
component: tests examples, tests and benchmarks

Comments

@ax3l
Copy link
Member

ax3l commented Oct 9, 2024 •
edited
Loading

Bugs like #707 might be able to be caught in CI if we enable signaling NaNs and arithmetic error throwing (AMReX options at runtime) for some of our CI runs.
@ax3l ax3l added the component: tests examples, tests and benchmarks label Oct 9, 2024
@ax3l
Copy link
Member Author

ax3l commented Oct 9, 2024 •
edited
Loading

We would inject them via a CMake option, only for CI, here:

impactx/examples/CMakeLists.txt

Lines 81 to 85 in 556153c

amrex.abort_on_unused_inputs=1
amrex.throw_exception = 1
amrex.signal_handling = 0
impactx.always_warn_immediately=1
impactx.abort_on_warning_threshold=low

@EZoni did something similar recently in WarpX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: tests examples, tests and benchmarks
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ax3l