Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allocate hist_coords to max dimensions rather than arbitrary limit #302

Open
peverwhee opened this issue Sep 23, 2024 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@peverwhee
Copy link
Collaborator

What is the feature/what would you like to discuss?

In src/history/cam_history_support.F90, we have:

integer,          parameter         :: maxmdims        = 25  ! arbitrary limit
type(hist_coord_t),          public :: hist_coords(maxmdims)

Instead, as pointed out by @nusbaume in #274, we should determine the biggest number of dimensions that were needed (based on the user_nl_cam history variables configured), and have the maxmdims value set to that (with hist_coords then an allocatable variable that is allocated to that size)

Is there anyone in particular you want to be part of this conversation?

No response

Will this change (regression test) answers?

No

Will you be implementing this enhancement yourself?

Any Software Engineer can do this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant