Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Skills for Part 2 Enemies #25

Open
wants to merge 19 commits into
base: CodeCleanupRefactor
Choose a base branch
from

Conversation

LeonardoTPereira
Copy link
Member

@LeonardoTPereira LeonardoTPereira commented Feb 22, 2023

Fix #6

  • Rearrange tables and skills files to new directories, so each skill is in the directory of their users
  • Adds tables for the skills from Mammon, Malformed Imp, Eunuch Sartyr and Golden Tormentor
  • Adds SOs for said skills and updates the enemies' SOs to contain said skills

Adds tables for new skills, the ones from mammon, malformed imp, eunuch sartyr and golden tormentor. Also adds their SOs or change the tables from the existing ones. Rearranges tables in directories according to their users.
@LeonardoTPereira LeonardoTPereira added the feature New feature or request label Feb 22, 2023
@LeonardoTPereira LeonardoTPereira added this to the Chapter 2 enemies milestone Feb 22, 2023
@LeonardoTPereira LeonardoTPereira self-assigned this Feb 22, 2023
@kori4r2 kori4r2 linked an issue Feb 22, 2023 that may be closed by this pull request
4 tasks
@kori4r2 kori4r2 self-requested a review February 22, 2023 18:28
Adds the cries sound files for the part 2 enemies and add them to their respective scriptable objects
Fixes enemies and skills tables where the floating point numbers were saved with comma instead of period.
Adds Malformed Imp AI.
Adds AI able to use the value inside the enemy's table as the chance to use their active skill.
Adds table for Vengeful Ghost data (was missing).
Fixes Golden Tormentor and Eunuch Satyr which were using the Wanderer's table.
Fixes all tables to have probabilities to use each skill.
@@ -45,7 +45,7 @@ MonoBehaviour:
_keyValues: 01000000
_keys: 01000000
_values:
- 0.5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This value should not be 5, it was probably caused by the floating point numbers in the status csv file being changed and using a comma instead of a point to indicate decimals

@@ -12,11 +12,11 @@ MonoBehaviour:
m_Script: {fileID: 11500000, guid: be7539eb7de5b5a4bbe1d928aafd8405, type: 3}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes like this, caused by playtesting can be ignored/reverted when committing, same as the one in the Hero SOs

Assets/Scripts/Scriptable Objects/Skill.cs Outdated Show resolved Hide resolved
Assets/Skills/BlackMageSkills/Anaemia.asset Outdated Show resolved Hide resolved
Assets/Tables/Bosses/Status Cerberus.csv Outdated Show resolved Hide resolved
Assets/Scripts/DynamicTable.cs Outdated Show resolved Hide resolved
Copy link
Contributor

@kori4r2 kori4r2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check the decimal character in these tables before merging
image

@kori4r2 kori4r2 linked an issue Mar 8, 2023 that may be closed by this pull request
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change Malformed IMP AI to use skills Create skill values tables
2 participants