-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bottom sheet modal overflows and content is missing on iOS 18.0.0 simulator. #1026
Comments
We're having the same issue. Works fine on iOS 17.x.x/Xcode 15.x.x, not working on iOS 18/Xcode 16. |
I can also reproduce this issue: I can fix the issue by running simulator: iPhone 15 Pro | iOS 17.5 Seems like it could be an issue with iOS 18.0 |
Have the same issue with Xcode16 and iOS18 simulator, the interesting thing is that it works in production build on real device. Update: also tested dev build on real device and it's working as well |
Yes I am also facing the same issue on Xcode16 and iOS18 simulator |
Same issue |
Same |
Hi @shonie2xx, I've been looking into this and have not been able to replicate it yet with iOS 18.0 & Xcode 16. Would you be able to provide a reproducible example that I could take a look at? Thank you. |
hi @m0hamad, the main problem is with ios18 simulator, did you test on real device? |
Hi @m0hamad, the issue is happening only on simulator and not physical device. iOS 18.0 Simulator & XCode 16. How can I further help you? |
@ashosipyan @shonie2xx Apologies for not being more specific. I tested on an iOS 18.0 simulator (16/16 Plus/16 Pro/16 Pro Max) with various react-native versions combined with different versions of react-native-app-auth and haven't had any luck replicating the issue yet. Are you also using Expo? |
I can reproduce the issue with:
|
@m0hamad hi, thank you for clarification, we are using:
if I try on simulator with iOS 17.5 and Xcode16 everything works fine, so for me the only issue is iOS18 simulator |
Hi @ashosipyan, I am still trying to replicate the issue. I noticed that there was a MacOS Sequoia re-release today and an update to the iOS 18 simulator along with the dev tools. Can you try updating and seeing if the issue persists afterwards? Thank you. |
I tried it out this morning doesn't fix the issue. Could it be something from the cocoapods version? We're running COCOAPODS: 1.15.2 |
@shonie2xx I also have the same COCOAPODS version (can see the version in the Podfile.lock file). I believe the best way to move forward would be for you to submit a reproducible example, I have not had any luck yet with reproducing this issue. Thank you. |
I'm also experiencing this issue after several years of successful usage with this IDP, only simulator issue as described.
usage: Reproduction steps:
Expected result:
Actual result:
Thanks. |
We are doing a little research around this issue, but it's going to be an upstream issue in either |
I've partially replicated this issue using Xcode 16.1 Beta 3 and iOS 18.1 Simulator. Interestingly - hitting the release icon at the top-right allows the content to load correctly. I can't replicate the layout issue from the original report, but the content fails to load. Once openid/AppAuth-iOS#871 is merged and released, I can check that using the latest version of |
We have now released 8.0.1 which includes an upstream API fix. Please retest. |
Unfortunately, still not fixed using iPhone 16 Pro simulator with iOS 18. |
Seems like iOS 18 problem: https://forums.developer.apple.com/forums/thread/764468 |
I can confirm this issue is still happening after installing version 8.0.1. Following https://forums.developer.apple.com/forums/thread/764468 I've noticed it indeed works if simulator is NOT rosetta. I do not use excluded architectures field so cannot comment on it. |
Issue
It seems the authorize method uses a modal, as the login page slides up from the bottom of the screen. On iOS 18.0.0, this modal is not displaying the content of the page and is not fitting within the screen. Below is a screenshot from the simulator:
Environment
Simulator iOS: 18.0.0
Simulator Device: iPhone 15 Pro, iPhone 16 Pro
Xcode: 16.0
macOS: Sequila 15.0
react-native: ^0.72.5
react-native-app-auth: 7.2.0 (also occurs on 8.0.0)
The text was updated successfully, but these errors were encountered: