Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Bug: incompleteTypes does not add correct type for Set #1519

Open
3 tasks done
rubiesonthesky opened this issue Apr 3, 2024 · 1 comment
Open
3 tasks done

🐛 Bug: incompleteTypes does not add correct type for Set #1519

rubiesonthesky opened this issue Apr 3, 2024 · 1 comment
Labels
status: needs reproduction The issue was filed with a missing or incomplete reproduction, and it can't be reproduced locally. type: bug Something isn't working :( 🐛

Comments

@rubiesonthesky
Copy link
Collaborator

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Expected

Should set the type to Set<ts.Type>

const assignedTypes = new ReadonlySet<ts.Type>();
const remainingMissingTypes: Set<ts.Type> = new Set(assignedTypes);

Actual

It sets the type to Set<any>

const assignedTypes = new ReadonlySet<ts.Type>();
const remainingMissingTypes: Set<any> = new Set(assignedTypes);

Additional Info

typestat.json

{
    "fixes": {
        "incompleteTypes": true,
    },
    "include": [
        "src/**/*.{ts,tsx}"
    ],
    "projectPath": "./tsconfig.json"
}

tsconfig.json

{
	"compilerOptions": {
		"declaration": true,
		"declarationMap": true,
		"esModuleInterop": true,
		"module": "NodeNext",
		"moduleResolution": "NodeNext",
		"noEmit": true,
		"outDir": "lib",
		"resolveJsonModule": true,
		"skipLibCheck": true,
		"sourceMap": true,
		"strict": true,
		"target": "ES2022"
	},
	"include": ["src", "test/*.ts"]
}
@rubiesonthesky rubiesonthesky added the type: bug Something isn't working :( 🐛 label Apr 3, 2024
@rubiesonthesky
Copy link
Collaborator Author

I'm not able to reproduce this in test setup right now.

The problem was found when running version 0.7.3 on this repo. So could it be that something fixed it or something else interfered and cause this problem?

I'm leaving this open for some time. Either I need better example to reproduce or this may have been fixed? I bet that the reproduce example is wrong, tho.

@rubiesonthesky rubiesonthesky added the status: needs reproduction The issue was filed with a missing or incomplete reproduction, and it can't be reproduced locally. label Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs reproduction The issue was filed with a missing or incomplete reproduction, and it can't be reproduced locally. type: bug Something isn't working :( 🐛
Projects
None yet
Development

No branches or pull requests

1 participant