Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDB: use a multiEntry index and 'structured' keys #867

Open
leplatrem opened this issue Oct 18, 2018 · 0 comments
Open

IDB: use a multiEntry index and 'structured' keys #867

leplatrem opened this issue Oct 18, 2018 · 0 comments
Labels
stale For marking issues as stale. Labeled issues will be closed soon if label is not removed.

Comments

@leplatrem
Copy link
Contributor

leplatrem commented Oct 18, 2018

As suggested by Andrew in https://bugzilla.mozilla.org/show_bug.cgi?id=1486980#c36

Example pseudocode:

objectStore.createIndex("app_indices", "appIndices", { multiEntry: true });

function fancyPut(idbDataStore, collectionName, collectionIndicesMap, appObj) {
  const appIndices = collectionIndicies.map([indexName, indexEvalPath]) => {
    // for the example, assume the key is not nested...
    const appVal = appObj[indexEvalPath];
    if (Array.isArray(appVal)) {
      throw new Error("The value can't be an array for our current bounds cleverness.");
    }
    // Create an index key that's array-structured so we can bound its
    // key-space.
    return [collectionName, indexName, appVal];
  });
  const wrappedObj = {
    actualObj: appObj
    appIndices
  };
  return idbDataStore.put(wrappedObj);
}

async function findWithIndex(idbDataStore, collectionName, indexName, appExact,
[appLow, appHigh]) {
  // [collectionName, indexName] lower-bounds all [collectionName, indexName, ...]
  // because a shorter array is by definition less than a longer array that is
  // equal up to their shared length.
  // [collectionName, indexName, []] upper-bounds all [collectionName, indexName, ...]
  // because arrays are always greater than strings/dates/numbers.  So as long
  // as the other contents of the index are non-arrays, we're good.
  const wholeIndexBounds = IDBKeyRange.bound(
    [collectionName, indexName],
    [collectionName, indexName, []],
    true, true); // exclusive range for the edge-case values.
  const exactIndexBounds = IDBKeyRange.only([collectionName, indexName, appValue]);
  const rangeBounds = IDBKeyRange.bound(
    [collectionName, indexName, appLow],
    [collectionName, indexName, appHigh],
    false, false); // assume caller meant inclusive.
  // DO ACTUAL INDEX STUFF
  return wrappedObj.actualObj;
}
@alexcottner alexcottner added the stale For marking issues as stale. Labeled issues will be closed soon if label is not removed. label Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale For marking issues as stale. Labeled issues will be closed soon if label is not removed.
Projects
None yet
Development

No branches or pull requests

2 participants