Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when no instance is being edited, show tabs for news and launcher settings #3

Open
MaxineHelsel opened this issue May 27, 2024 · 6 comments

Comments

@MaxineHelsel
Copy link

No description provided.

@Lamby777
Copy link
Owner

Lamby777 commented May 28, 2024

the "when" part is done, just need a way to get news into the launcher (thing we talked over discord about)

52064f0

@MaxineHelsel
Copy link
Author

MaxineHelsel commented May 29, 2024 via email

@Lamby777
Copy link
Owner

Lamby777 commented May 29, 2024

Does this include the tab for launcher specific settings? (Eg. Language, reset, manual dark/light toggle, instance save location, button to pull up save location in file manager, etc)

This should be a separate menu, so that you can still configure launcher settings without having to restart the launcher if you pressed Edit and the menu is gone. I could add a settings button in the top right or something.

@Lamby777
Copy link
Owner

Lamby777 commented Jun 3, 2024

@MaxineHelsel Actually, we could do this... How about if the "Edit" menu had an X you could click to go back to the page that had the news/settings tabs on it?

@MaxineHelsel
Copy link
Author

i like that exactly

in default you would see news/settings/etc tabs, and when you hit edit it would "overlay" that with the edit menu

@Lamby777
Copy link
Owner

Lamby777 commented Jun 3, 2024

alright everything's done except the "tabs" functionality.

also fwiw i could change the edit panel to just be a display: none; instead of using template tags because templates are fucking annoying to instantiate and i only need 1 edit panel at a time anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants