Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Allow ScheduleWorkflowActive to accept SAT,SUN without times of day #247

Open
wakco opened this issue Oct 29, 2024 · 1 comment
Labels
enhancement New feature or request
Milestone

Comments

@wakco
Copy link
Contributor

wakco commented Oct 29, 2024

While --schedule-workflow-active and ScheduleWorkflowActive allow TUE:13:00-17:00,WED:13:00-17:00,THU:13:00-17:00 and TUE:13:00-17:00,WED:1:00-7:00,WED:13:00-17:00,THU:13:00-17:00, it still requires that definition of time of day, meaning for say limiting it to just the weekend, we are required to enter SAT:00:00-23:59,SUN:00:00-23:59 which raises the question, what happens during that one minute from 23:59 to 00:00 (I assume those times are inclusive, so 23:59 would actually include 23:59:59 .9 recurring, but I haven't checked the code).

Either way it would be nicer, simpler if the :hour:minute-hour:minute were optional, allowing setting just the day to mean the full day. i.e. SAT,SUN would allow all weekend.

@Macjutsu Macjutsu added the enhancement New feature or request label Oct 29, 2024
@Macjutsu Macjutsu added this to the v5.x.x milestone Oct 29, 2024
@Macjutsu
Copy link
Owner

That last miniute is inclusive, but there should be an option to not have to define a time for allowing the full day.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants