Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: remove diagnostics from notices #110

Open
mcollina opened this issue Feb 1, 2024 · 4 comments
Open

github: remove diagnostics from notices #110

mcollina opened this issue Feb 1, 2024 · 4 comments

Comments

@mcollina
Copy link

mcollina commented Feb 1, 2024

I don't think adding diagnostic info as "notice" is helpful. It would cause a reduction in the use of diagnostics, which can be helpful.

Screenshot 2024-02-01 at 12 16 23

This is likely related to #109.

@MoLow
Copy link
Owner

MoLow commented Feb 1, 2024

@mcollina you would have preferred to only see these in the stdout/spec/tap reporter?

@mcollina
Copy link
Author

mcollina commented Feb 1, 2024

yes exactly

@MoLow
Copy link
Owner

MoLow commented Feb 1, 2024

@mcollina I have released a new version to npm, can you check if the latest changes make more sense and if you still feel this is needed?

@mcollina
Copy link
Author

mcollina commented Feb 1, 2024

I would still prefer not to see them, but maybe put it behind an env? I can see folks using this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants