You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There have been several instances where cylc has said that the `remap-pp-components task has executed successfully even though it didn't. Two instances where this occurred for me are:
When the pp_chunk_a variable in my pp yaml did not match the chunksize that fre inferred from my history files, causing the remap script to simply do nothing at this point in the loop:
These problems were quite difficult to debug becausecylc, job.out, and job.err all seemed to indicate that the remap job had completed successfully when they had just failed silently. There could also be several other points where this loop could fail / skip an iteration and the function would still return 0 and print "Component reamapping complete" without actually executing the copy command.
I think it would be helpful to at least add a check before printing that the remapping completed successfully, so that if the files aren't copied to output_dir the user knows to check this script for issues instead of having cylc fail at some future workflow step that may not be related.
The text was updated successfully, but these errors were encountered:
There have been several instances where cylc has said that the `remap-pp-components task has executed successfully even though it didn't. Two instances where this occurred for me are:
When the
pp_chunk_a
variable in my pp yaml did not match thechunksize
that fre inferred from my history files, causing the remap script to simply do nothing at this point in the loop:fre-workflows/app/remap-pp-components/bin/remap-pp-components
Lines 378 to 380 in c18dedd
If the link command fails, the remap script also doesn't do anything when it gets a non-zero return value
fre-workflows/app/remap-pp-components/bin/remap-pp-components
Lines 451 to 464 in c18dedd
These problems were quite difficult to debug because
cylc
,job.out
, andjob.err
all seemed to indicate that the remap job had completed successfully when they had just failed silently. There could also be several other points where this loop could fail / skip an iteration and the function would still return 0 and print "Component reamapping complete" without actually executing the copy command.I think it would be helpful to at least add a check before printing that the remapping completed successfully, so that if the files aren't copied to output_dir the user knows to check this script for issues instead of having cylc fail at some future workflow step that may not be related.
The text was updated successfully, but these errors were encountered: