Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

app/regrid-xy/regrid_xy.py should use pathlib for filepath parsing #31

Open
ceblanton opened this issue Sep 26, 2024 · 0 comments · May be fixed by #32
Open

app/regrid-xy/regrid_xy.py should use pathlib for filepath parsing #31

ceblanton opened this issue Sep 26, 2024 · 0 comments · May be fixed by #32

Comments

@ceblanton
Copy link
Contributor

ceblanton commented Sep 26, 2024 •
edited
Loading

There's a sort-of typo in regrid_xy.py that causes the TMPDIR to be malformed:

work_dir = tmp_dir + 'work/'

The real problem is that it's forming filepaths by hand which is error prone.
ceblanton pushed a commit that referenced this issue Sep 26, 2024
#31 Use pathlib for filepath parsing, and cleanup
1f1293b 
- remove undesired fms-user remap cache "feature"
- remove some commented code
- add automatic exit code checking for the fregrid system calls
ceblanton pushed a commit to ceblanton/fre-workflows that referenced this issue Sep 27, 2024
NOAA-GFDL#31 Replaced most of regrid-xy string filepath parsing with…
332be9a 
… pathlib
@ceblanton ceblanton linked a pull request Sep 27, 2024 that will close this issue
Open
@ilaflott ilaflott mentioned this issue Oct 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

regrid-xy scripting to use pathlib for filename parsing ceblanton/fre-workflows
1 participant
@ceblanton