Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Runtime Feature]: Add support for more than one portal pair #663

Open
wolfestridershooter opened this issue Oct 27, 2024 · 2 comments
Open
Labels
feature jira A jira ticket exists runtime RTX Remix runtime

Comments

@wolfestridershooter
Copy link

wolfestridershooter commented Oct 27, 2024

What is the context of the feature/improvement?

Since Portal 2 now works with RTX Remix we need support for more than one portal pair. In the singleplayer campaign there are places where two portal pairs are required, co-op has four. There are even scenarios where Portal 2 can have over 64 portals open at once so the limit should be more than marginally increased.

Please describe the feature/improvement?

Add support for more than one portal pair.

What would be your solution? (optional)

No response

Version

f80a3a2-667-release

Media

image
You should be able to see out of this door (there is a world portal in the door that goes to another part of the map) but since we only have one portal pair this world portal doesn't work^

@xoxor4d
Copy link

xoxor4d commented Oct 28, 2024

I've actually started working on this myself and got 3 pairs working fine (virtual instances should work as well - the viewmodel does at least): xoxor4d/dxvk-remix@73fb07d#diff-20442ebd2aae244d99494afb6d91a018fab1cfe887216bf500592a1954653c3dR1523

I'm having some trouble with:

  • Understanding portal spaces (as it's only using two bits => a max of 3 portal spaces?)
  • Do I even need to worry about other portal spaces? (I did include some commented changes in that regard)

This also includes a fix for virtual instances where the world transform == identity (transform is baked into the vertices) by using the centroid of the bounding box (enabled if enableAlwaysCalculateAABB is active).
Virtual instances are not working otherwise (as the world pos of the player body texture will always be at 0 0 0)

@NV-LL
Copy link
Collaborator

NV-LL commented Oct 30, 2024

Thanks for reaching out! We've opened REMIX-3677 for internal tracking.

@NV-LL NV-LL added jira A jira ticket exists and removed triage labels Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature jira A jira ticket exists runtime RTX Remix runtime
Projects
None yet
Development

No branches or pull requests

3 participants