From 73a689034d842dacfeab3cc80ebca0466a4fe03e Mon Sep 17 00:00:00 2001 From: Trevor Harris Date: Thu, 21 Nov 2024 07:53:00 -0800 Subject: [PATCH] Revert "Add Open App Store & Notify App Install Completed Capability (#2626)" (#2636) This partially reverts commit b558cec5d9687ce03bdf0f9eda70303866ea0491. --- .../e2e-test-data/otherAppStateChange.json | 13 +- apps/teams-test-app/e2e-test-data/store.json | 118 ------------------ 2 files changed, 4 insertions(+), 127 deletions(-) delete mode 100644 apps/teams-test-app/e2e-test-data/store.json diff --git a/apps/teams-test-app/e2e-test-data/otherAppStateChange.json b/apps/teams-test-app/e2e-test-data/otherAppStateChange.json index d52f39f24a..73f978b966 100644 --- a/apps/teams-test-app/e2e-test-data/otherAppStateChange.json +++ b/apps/teams-test-app/e2e-test-data/otherAppStateChange.json @@ -23,9 +23,10 @@ "type": "registerAndRaiseEvent", "boxSelector": "#box_otherAppStateChange_registerInstallHandler", "eventName": "otherApp.install", - "eventData": { - "appIds": ["123", "456"] - }, + "eventData": + { + "appIds": ["123", "456"] + }, "expectedTestAppValue": "received" }, { @@ -33,12 +34,6 @@ "type": "callResponse", "boxSelector": "#box_otherAppStateChange_unregisterInstallHandler", "expectedTestAppValue": "received" - }, - { - "title": "notifyInstallCompleted - Success", - "type": "callResponse", - "boxSelector": "#box_otherAppStateChange_notifyInstallCompleted", - "expectedTestAppValue": "notified" } ] } diff --git a/apps/teams-test-app/e2e-test-data/store.json b/apps/teams-test-app/e2e-test-data/store.json deleted file mode 100644 index 7eded22367..0000000000 --- a/apps/teams-test-app/e2e-test-data/store.json +++ /dev/null @@ -1,118 +0,0 @@ -{ - "name": "Store", - "platforms": "Web", - "checkIsSupported": { - "domElementName": "checkCapabilityStore" - }, - "version": ">2.31.0", - "hostSdkVersion": { - "web": ">4.5.0" - }, - "testCases": [ - { - "title": "openStoreExperience API Call Full Store - Success", - "type": "callResponse", - "boxSelector": "#box_storeOpen", - "inputValue": { - "dialogType": "fullstore" - }, - "expectedAlertValue": "openStoreExperience called with ##JSON_INPUT_VALUE##" - }, - { - "title": "openStoreExperience API Call In-Context-Store - Success", - "type": "callResponse", - "boxSelector": "#box_storeOpen", - "inputValue": { - "dialogType": "ics" - }, - "expectedAlertValue": "openStoreExperience called with ##JSON_INPUT_VALUE##" - }, - { - "title": "openStoreExperience API Call App Detail - Success", - "type": "callResponse", - "boxSelector": "#box_storeOpen", - "inputValue": { - "dialogType": "appdetail", - "appId": "1542629c-01b3-4a6d-8f76-1938b779e48d" - }, - "expectedAlertValue": "openStoreExperience called with ##JSON_INPUT_VALUE##" - }, - { - "title": "openStoreExperience API Call App Detail With Invalid AppId - Fail", - "type": "callResponse", - "boxSelector": "#box_storeOpen", - "inputValue": { - "dialogType": "appdetail", - "appId": "123" - }, - "expectedTestAppValue": "Error: Error: Potential app id (123) is invalid; its length 3 is not within the length limits (4-256)." - }, - { - "title": "openStoreExperience API Call App Detail With Empty AppId - Fail", - "type": "callResponse", - "boxSelector": "#box_storeOpen", - "inputValue": { - "dialogType": "appdetail", - "appId": "" - }, - "expectedTestAppValue": "Error: Error: Potential app id () is invalid; its length 0 is not within the length limits (4-256)." - }, - { - "title": "openStoreExperience API Call App Detail Without AppId - Fail", - "type": "callResponse", - "boxSelector": "#box_storeOpen", - "inputValue": { - "dialogType": "appdetail" - }, - "expectedTestAppValue": "Error: Error: No App Id present, but AppId needed to open AppDetail store" - }, - { - "title": "openStoreExperience API Call Specific Store - Success", - "type": "callResponse", - "boxSelector": "#box_storeOpen", - "inputValue": { - "dialogType": "specificstore", - "collectionId": "copilotplugins" - }, - "expectedAlertValue": "openStoreExperience called with ##JSON_INPUT_VALUE##" - }, - { - "title": "openStoreExperience API Call Specific Store With Empty CollectionId - Fail", - "type": "callResponse", - "boxSelector": "#box_storeOpen", - "inputValue": { - "dialogType": "specificstore", - "collectionId": "" - }, - "expectedTestAppValue": "Error: Error: No Collection Id present, but CollectionId needed to open a store specific to a collection" - }, - { - "title": "openStoreExperience API Call Specific Store Without CollectionId - Fail", - "type": "callResponse", - "boxSelector": "#box_storeOpen", - "inputValue": { - "dialogType": "specificstore" - }, - "expectedTestAppValue": "Error: Error: No Collection Id present, but CollectionId needed to open a store specific to a collection" - }, - { - "title": "openStoreExperience API Call With Invalid Dialog Type - Fail", - "type": "callResponse", - "boxSelector": "#box_storeOpen", - "inputValue": { - "dialogType": "123" - }, - "expectedTestAppValue": "Error: Error: Invalid store dialog type, but type needed to specify store to open" - }, - { - "title": "openStoreExperience API Call Without Permission - Fail", - "type": "callResponse", - "boxSelector": "#box_storeOpen", - "inputValue": { - "dialogType": "fullstore" - }, - "testUrlParams": [["appDefOverrides", "{\"isFullTrustApp\": false, \"isMicrosoftOwned\": false}"]], - "expectedTestAppValue": "Error: Error: 500, message: App does not have the required permissions for this operation" - } - ] -}