Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HUD displayed although log buffer is opened #621

Open
nimaai opened this issue Nov 20, 2024 · 4 comments
Open

HUD displayed although log buffer is opened #621

nimaai opened this issue Nov 20, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@nimaai
Copy link

nimaai commented Nov 20, 2024

I don't know if this is expected behaviour but I would prefer that the HUD be displayed only if the log buffer is not opened.

I like to use both: HUD for small eval results and log buffer for big ones.

Thanks.

@russtoku
Copy link
Contributor

I don't normally use the HUD but I changed my config to allow it. I noticed that after a handful of evaluations with the log buffer opened in a horizontal split the HUD will display.

@Olical Olical added the bug Something isn't working label Nov 22, 2024
@Olical
Copy link
Owner

Olical commented Nov 22, 2024

Related to #615, there's a misconception or a bug here. Not sure which, maybe both!

The HUD appears if the log has been appended to when the bottom of it is off screen. So if you have the log open but you're looking at the top and something is added to the bottom, 1000 lines away, the HUD will appear to show that new content.

If you're seeing output at the bottom of the log and the HUD is appearing then that behaviour is maybe not working as intended. I think some people would prefer the HUD to never appear if a log buffer is open though, so to give those people a choice, how about I make the behaviour an enum.

The default being "show HUD if new log lines aren't visible" and an alternate behaviour being "show HUD is log isn't open in this tab" - because a log in another tab shouldn't stop the HUD appearing in my opinion.

Thoughts?

@nimaai
Copy link
Author

nimaai commented Nov 22, 2024

@Olical

perfect solution from my point of view.

@russtoku
Copy link
Contributor

Agreed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants