Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeout drop doesn't work since Jan 02, 2013 commit by LloydPickering #85

Open
korj opened this issue Oct 1, 2013 · 2 comments
Open

Comments

@korj
Copy link

korj commented Oct 1, 2013

The problem is that server never drops clients after timeout. What's interesting, it worked with nugget package of Alchemy WebSockets, but when I cloned git repo and compile last commit from master I noticed timeout never drops. Seems nugget package compiled not from the latest version?

bdefe79 - is the last commit that works correctly with timeout. After there was a lot of changes in WebSocketsServer.cs, especially in OnRunClient method

@jhaygood86
Copy link
Contributor

I see the problem here. The old code depending on the semaphore, the new code does not (async based). We do have a cleanup thread, but it doesn't pay attention to the timeout. I'll see if I can whip up a pull request to do that.

@jhaygood86
Copy link
Contributor

(I think you are write on nuget not being updated from github)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants