Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visibility too restrictive for externally defined C++ nodes & adapters #363

Open
wrieg123 opened this issue Sep 29, 2024 · 5 comments
Open
Labels
lang: c++ Issues and PRs related to the C++ codebase type: bug Concrete, reproducible bugs

Comments

@wrieg123
Copy link
Collaborator

wrieg123 commented Sep 29, 2024

Describe the bug
This PR introduced hidden visibility for most symbols in the build on non-windows machines. Unfortunately, this hides too many symbols that would be used in external C++ adapters and node definitions.

Error Message
(from build then run of the c++ example nodes, for instance)
symbol not found in flat namespace __________

@wrieg123 wrieg123 added type: bug Concrete, reproducible bugs lang: c++ Issues and PRs related to the C++ codebase labels Sep 29, 2024
@robambalu
Copy link
Collaborator

Can you paste the actual link error that you hit

@wrieg123
Copy link
Collaborator Author

wrieg123 commented Sep 29, 2024

symbol not found in flat namespace '__ZN3csp4Node11createAlarmERNSt3__110shared_ptrIKNS_7CspTypeEEEm'
symbol not found in flat namespace '__ZN3csp4EnumINS_7CspType10TypeTraitsEE7mappingEv'
symbol not found in flat namespace '__ZN3csp12CspArrayType6createERKNSt3__110shared_ptrIKNS_7CspTypeEEEb'

createAlarm from a node definition. While Enum and CspArrayType are from the partially defined func's used in the various message mappers.

@wrieg123
Copy link
Collaborator Author

From this example

symbol not found in flat namespace '__ZN3csp14CycleStepTable8scheduleEPNS_8ConsumerE'

@AdamGlustein
Copy link
Collaborator

Thanks Will - I can repro this using our CPP examples. As @svatasoiu is out for the next 2 weeks I'll try to take a look at a fix.

@wrieg123
Copy link
Collaborator Author

No problem. I'll try to produce a repro using an adapter or types sometime this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang: c++ Issues and PRs related to the C++ codebase type: bug Concrete, reproducible bugs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants