Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generalize the function get_path_value_from_dict in kubernetes and json handler and move it to common.py #145

Open
4 tasks
samriddhi99 opened this issue Jul 24, 2024 · 0 comments
Open
4 tasks

Generalize the function get_path_value_from_dict in kubernetes and json handler and move it to common.py #145

samriddhi99 opened this issue Jul 24, 2024 · 0 comments

Comments

@samriddhi99
Copy link
Collaborator

The function get_path_value_from_dict is currently duplicated in both the Kubernetes handler and JSON handler files. To improve code maintainability and reusability, we need to generalize this function and move it to common.py.

  • Update the function to handle more generic use cases.
  • Place the generalized function in common.py and ensure all relevant imports and dependencies are updated accordingly.
  • Modify the Kubernetes and JSON handler files to import the function from common.py.
  • Ensure existing tests in Kubernetes and JSON handlers pass with the new implementation.
AkashS0510 added a commit to AkashS0510/tirith that referenced this issue Aug 4, 2024
@AkashS0510
Resolved - Generalize the function get_path_value_from_dict
07b989a 
StackGuardian#145

Refactor get_path_value_from_dict

Moved get_path_value_from_dict to common.py.
Refactored Kubernetes and JSON handler files to import from common.py.
@AkashS0510 AkashS0510 mentioned this issue Aug 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@samriddhi99