Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stalled/terminated runs cleanup #12

Open
zloster opened this issue Apr 16, 2019 · 1 comment
Open

Stalled/terminated runs cleanup #12

zloster opened this issue Apr 16, 2019 · 1 comment
Assignees
@michaelhixson

Comments

@zloster
Copy link

zloster commented Apr 16, 2019

If there is some problem with a run in Citrine and a new run is started tfb-status still displays information about estimated remaining time for the old run.
Some details here: TechEmpower/FrameworkBenchmarks#4634 (comment)
@michaelhixson
Copy link
Contributor

michaelhixson commented Apr 16, 2019 •
edited
Loading

Notes to self about how to fix this:

Currently, our ResultsJsonView objects have elapsedDuration and estimatedRemainingDuration properties that are calculated relative to the current wall clock time.

tfb-status/src/main/java/tfb/status/service/HomeResultsReader.java

Line 346 in 4763e10

? LocalDateTime.now(clock)

It's not appropriate for those properties to be in ResultsJsonView since ResultsJsonView is cached (and the cached object is only forgotten when a new results.json file is uploaded). Those current-time-relative properties should be moved up to ResultsView, which is recreated on every incoming request.

Once those properties are on ResultsView, we can change the way estimatedRemainingDuration is presented such that if it's been 24h (or some other arbitrary amount of time) since the last update, we display "Run did not complete" or something.

@michaelhixson michaelhixson self-assigned this Apr 16, 2019
michaelhixson added a commit that referenced this issue Apr 18, 2019
@michaelhixson
Decouple run summary properties from specific file types
21f3b3f 
This lets us display runs on the home page and results detail page
properly when there is only a results.zip file and no standalone
results.json file.

Fixes #11

This also moves us closer to a fix for #12, since the properties that are
relative to the current wall clock time are no longer being cached.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michaelhixson michaelhixson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@michaelhixson @zloster