Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal without Jetpack Navigation #1473

Open
naixx opened this issue Aug 13, 2024 · 1 comment
Open

Modal without Jetpack Navigation #1473

naixx opened this issue Aug 13, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@naixx
Copy link

naixx commented Aug 13, 2024

Is your feature request related to a problem? Please describe.
Currently, the whole SDK is tightly coupled with Jetpack navigation. For the apps that use alternative navigation libraries like Voyager or Decompose it is extremely frustrating to integrate SDK. Even if someone wants to use Web3ModalComponent there is additional transitive dependency that is not required by the developer.

Describe the solution you'd like
SDK should provide navigation agnostic option or a clear example of how to use it.

Describe alternatives you've considered
Currently I try to integrate Web3ModalComponent into existing app and I can't do that without jetpack navigation. Having two nav libs is not what you want.

Additional context
Ideally, you should have a KMP version with low number of dependencies

@naixx naixx added the enhancement New feature or request label Aug 13, 2024
@Raenar4k
Copy link

Yeah. Jetpack navigation also introduces issues, when WC uses older version and your up has newer one. This already caused frustrating crashes before:
#1299 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants