Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🖌️ Minor visual clarity upgrades #17

Open
JFWooten4 opened this issue Sep 18, 2024 · 3 comments
Open

🖌️ Minor visual clarity upgrades #17

JFWooten4 opened this issue Sep 18, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@JFWooten4
Copy link
Member

JFWooten4 commented Sep 18, 2024

Excited to see the recent progress in stylizing the database for easy use. 📈 Thank you for all the incredible contributions!


Might we clean up a couple small display items? 🖥️

Sidebar Selected Font

Might we make this text color darker (for contrast)?

Screenshot 2024-09-18 at 5 16 28 AM

Header Title Spacing

Maybe this is just me, but do you think IR Email looks better than I R Email? 📝

Screenshot 2024-09-18 at 5 27 30 AM
@JamesAlfonse
Copy link
Member

JamesAlfonse commented Sep 18, 2024

Agreed on both thoughts here. I also wanted to reverse the colors on the selected/unselected options so that the unselected options would be grayed out instead. The column names in the .db file don't have any spaces in them, which is where I think the issue stems from. I had run into some problems when they had spaces in them, it might be good to circle back and figure out a solution for this.
Also noticed that enabling and disabling columns on the site doesn't shrink the table; enabling all the columns then disabling all but one will leave a massive amount of space for just that one column.

@JamesAlfonse JamesAlfonse added P5 - Lowest enhancement New feature or request and removed enhancement New feature or request labels Oct 19, 2024
@JamesAlfonse JamesAlfonse self-assigned this Oct 20, 2024
@JamesAlfonse JamesAlfonse moved this from Technical to In Progress in Organization Issues Oct 20, 2024
@JamesAlfonse
Copy link
Member

Screenshot 2024-10-20 at 5 31 06 PM

Added readability to these buttons, but have not been able to make progress on adjusting the colors between the active and non-active buttons. The active buttons look like they're pressed in, but adjusting the colors in the css file for the section below does not work. #134F9B should be a blue color. It's possible that there's a conflict between the css code and the datatables library causing this. One solution could be to download the full library and include it in this repository to have more visible control over the styling. Regardless, I would prefer to look at other stack alternatives first before proceeding with this option #8. I will look into fixing the headers next.

/* Styles for active buttons using aria-pressed attribute /
div.dt-button-collection .dt-button[aria-pressed="true"] {
/
Set background color for active buttons /
background-color: #134F9B !important;
/
Set text color for active buttons */
color: #FFFFFF !important;
}

@JamesAlfonse JamesAlfonse removed their assignment Oct 25, 2024
@JFWooten4
Copy link
Member Author

@JamesAlfonse Far above my paygrade. 🤯 Thank you for both tackling this crucial challenge, and for sharing the process with us here—both via your thoughts and documenting actions which can so often get lost in git commit gibberish.1 Seriously appreciate the choice to analyze the framework approach before hastling with the unresponsive colors. 🎨

Footnotes

  1. And thanks for un-assigning yourself! I know this is only available to people who have write access, but it's super useful when I'm scanning through issues. In my view, the worst feeling you can have is when you're working on something (as shown through either an assignment declaration or a draft PR mentioned in comments on the issue), but then someone else just drops the same work already completed in a new PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants