-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to suppress job summary #126
Comments
@Pesa do you have a preference for how the attestation URL output should look? It would be pretty straightforward if there was only ever a single attestation generated. But with the possibility of multiple attestations, it's a bit more complex . . .
Other ideas? |
Ah, good question. I did not think of the case of multiple attestations. I don't have a strong preference, I've seen other actions use either JSON, comma-separated, or newline-separated lists. I suppose using JSON would be the most general, flexible, and future-proof approach (action consumers can use fromJSON to access individual IDs/URLs), though one could also say it's the most overkill. An additional issue is that it's not obvious what artifact each attestation ID corresponds to. A possibly overkill solution would be to output a JSON object for each generated attestation, containing: |
There is some work to do still to figure out the best way to output the list of attestation links, but the 1.4.0 release does give you the option to suppress the summary output. |
Fixes actions#126 Add option to suppress job summary and provide attestation URL output. * Add `suppress-summary` input parameter to `action.yml` to control job summary suppression. * Add `attestation-url` output parameter to `action.yml` to provide attestation URL. * Import `getInput` and `setOutput` functions from `@actions/core` in `src/main.ts`. * Check `suppress-summary` input value and conditionally skip summary generation in `src/main.ts`. * Set `attestation-url` output with generated attestation URL in `src/main.ts`. * Add `generateAttestationUrl` and `generateSummary` functions in `src/main.ts`. * Update tests in `__tests__/main.test.ts` to cover `suppress-summary` input and verify `attestation-url` output. * Add test for JSON output format for multiple attestations in `__tests__/main.test.ts`. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/actions/attest-build-provenance/issues/126?shareId=XXXX-XXXX-XXXX-XXXX).
I'd like to disable the built-in job summary and instead generate my own attestation summary and combine it with the summary that I'm already generating for the job. In order to do this, I'd need to:
actions/attest-build-provenance
to suppress the generation of the built-in job summaryactions/attest-build-provenance
(AFAICS the action doesn't currently provide this information)The text was updated successfully, but these errors were encountered: