Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests: Build and run WebRTC unit tests #10

Closed
aisouard opened this issue Oct 14, 2016 · 4 comments
Closed

Tests: Build and run WebRTC unit tests #10

aisouard opened this issue Oct 14, 2016 · 4 comments
Labels
cmake jake testing
Milestone
1.1

Comments

@aisouard
Copy link
Owner

No description provided.

@aisouard aisouard added this to the 0.0.2 milestone Oct 14, 2016
@muellni
Copy link

muellni commented Mar 30, 2017

I want to use webrtc/api/test/fakeaudiocapturemodule.h for my build of node-webrtc.
While webrtc/api/BUILD.gn seems to use the rtc_include_tests option for building the webrtc/api/test/* files, it looks like the -DBUILD_TESTS=ON cmake-option doesn't enable it anymore, is that correct?
Do you see any way to fix that?

aisouard added a commit that referenced this issue Mar 30, 2017
@aisouard
(#10): Add webrtc_tests target to ninja build command
f496ce1
@aisouard
Copy link
Owner Author

The BUILD_TESTS flag wasn't taken into account inside the webrtc-src CMake target.
I have no other choice than building all the test binaries, this will add 933 files to compile and I hope that it won't reopen #32.

Testing under branch build-unit-tests

aisouard added a commit that referenced this issue Mar 30, 2017
@aisouard
(#10): Enable test building under CIs
8a5038f
@aisouard
Copy link
Owner Author

Travis takes too much time to compile the library with unit tests.
I'll retry tonight on my own machines then close the issue.

aisouard added a commit that referenced this issue Mar 30, 2017
@aisouard
(#10): State BUILD_TESTS variable inside the README and CHANGELOG
8d571cb
@aisouard
Copy link
Owner Author

Merged in branch dev.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cmake jake testing
Projects
None yet
Milestone
1.1
Development

No branches or pull requests
2 participants
@muellni @aisouard