Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It would be nice not to force openssl version that comes with webrtc #76

Open
pps83 opened this issue Dec 12, 2018 · 2 comments
Open

It would be nice not to force openssl version that comes with webrtc #76

pps83 opened this issue Dec 12, 2018 · 2 comments

Comments

@pps83
Copy link

pps83 commented Dec 12, 2018

Otherwise, any project that already uses openssl won't be able to use this libwebrtc, since two openssl versions will produce link errors.

On top of that clean/rebuild absolutely has to work, otherwise it's extremely misleading: you may need to edit some webrtc code and ... you will not get anything rebuild if you use libwebrtc.

@agouaillard
Copy link

  • these are two different issues, you might want to open two separate tickets.
  • the goal of the project is to provide packaged versions of pre-compiled libwebrtc and headers. The source code is not provided in the package and you are not supposed to modify it dynamically.
  • if you want to use the source code, you re better off using directly the webrtc.org code.
  • linking against OpenSSL is not a direct option provided by the source code whose control is outside the scope of this project. If you think support for OpenSSL should be reinstated in libwebrtc, you should open a bug/ticket and let Google know: webrtc.org
  • there are ways around the symbols mismatch without recompiling against OpenSSL:
    — compile in different translation units (ie use plugins, a C API or a DLL to wrap around the conflicting symbols)
    — use the pimpl design pattern,
    — strip the symbols from the libwebrtc not to export them (they will then be internal to libwebrtc).

@pps83
Copy link
Author

pps83 commented Dec 22, 2018

there are ways around the symbols mismatch without recompiling against OpenSSL

In my case I can only use static build (no dlls) and linking will always fail in such cases if your project happens to use openssl regardless if you strip openssl symbols from webrtc or not. I build on Windows if that matters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants