Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for a credential provider #246

Open
trentbitterman opened this issue Nov 14, 2024 · 2 comments
Open

Add support for a credential provider #246

trentbitterman opened this issue Nov 14, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@trentbitterman
Copy link

trentbitterman commented Nov 14, 2024

Currently, coredis allows authenticating with Redis clusters by supplying a username and password. This works in most situations, but in some cases, such as an Elasticache cluster using IAM for auth, this can't be used as the "password" will rotate and there's no good way in coredis to update the password when it does. Other Redis libraries, such as redis-py, allow the specification of a credential provider, which is basically just an object with a get_credential method that will return the current password when called. It would be useful if coredis had something similar.

Expected Behaviour

In addition to supporting a password string parameter, the various coredis clients should also allow passing in a credential provider object that coredis can use to query the password/credential whenever it is needed.

Thanks for all of your work on this library. It's really great!

@trentbitterman trentbitterman added the enhancement New feature or request label Nov 14, 2024
@alisaifee alisaifee self-assigned this Nov 26, 2024
@alisaifee
Copy link
Owner

Apologies for the late response. This makes a lot of sense and would be a pretty straightforward addition to the API. I'm open to a PR for this as I've had limited bandwidth recently for maintenance, however, if not - I'd appreciate any suggestions regarding which providers make sense as builtins versus just being documented as recipes or suggestions in the documentation.

@trentbitterman
Copy link
Author

No worries. I'll work on putting something together and hopefully have a PR up sometime next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants