_context: use artifact caches from the parent project for junctions #1941
Conversation
abderrahim
requested review from
gtristan,
juergbi,
BenjaminSchubert and
cs-shadow
as code owners
abderrahim
force-pushed
the
abderrahim/junction-remotes
branch
from
fca3645
to
cbe213c
Compare
|
commit 24c0de1 was intentionally reverted as part of https://gitlab.com/BuildStream/buildstream/-/merge_requests/1403. The remote cache configuration was later redesigned in #1434. I have to dive deeper to figure out whether this is a correct bug fix, but want to make sure we don't unintentionally change the behavior (away from the agreed design). And we would also need to consider whether this behavior change may break any users. |
Yeah, the problem is that there is no agreed design. The mailing list post around #1434 didn't elaborate on this point precisely and my reading of it didn't seem to contradict my understanding of it. However, it was ultimately merged without much discussion. My research didn't lead me to https://gitlab.com/BuildStream/buildstream/-/merge_requests/1403 (I wasn't on the mailing list back then). I still need to read the whole discussion around that change. This change brings back the behaviour that we have been using for a long time on buildstream 1.x. I'll try to post on the mailing list with a summary of my research and make a case for this change.
Do you have an idea of who these users might be? In all buildstream projects I worked on, this is the right thing to do. |
|
@juergbi this has a real monetary impact on any project used as base project that has to pay for bandwidth and discourages such projects from having public artifact caches. It doesn't seem like decision that is matter of gut feeling. Current behaviour is bad for BuildStream community. |
This makes a junction use the artifact cache of the parent project before the ones defined for the junction
This was originally done in 24c0de1, but regressed at some point
Fixes #1839