Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pullup over <ion-tabs> #35

Open
shobhitchittora opened this issue Mar 2, 2017 · 5 comments
Open

Pullup over <ion-tabs> #35

shobhitchittora opened this issue Mar 2, 2017 · 5 comments

Comments

@shobhitchittora
Copy link

shobhitchittora commented Mar 2, 2017

Hi all,
Can someone please help me with adding ionic-pullup over ion-tabs. I have a tabs layout with tabs at the bottom. and I have to show the pullup over the tabs and toggle when a backdrop is clicked. Currently the pullup goes behind the ion-tabs element.

@arielfaur
Copy link
Owner

Is this Ionic 1 or 2?

@shobhitchittora
Copy link
Author

This is in Ionic 2.

@arielfaur
Copy link
Owner

Can you create a Plunker with your code so I can test your use case?

@shobhitchittora
Copy link
Author

Hey. I was trying to make the pullup come over the <ion-tabs>, but finally modified my design to allow pullup to come above the <ion-tabs> as is the default behaviour. Additionally I'd like to contribute to the project. I have a problem with the Keyboard plugin when using <ion-pullup>. The pullup just scrolls up with the keyboard. I'd like to fix this in a pull request. Please guide me on this.

@arielfaur
Copy link
Owner

The pullup footer will be placed above the tabs by default. In any case I am not sure it is a valid use case to have both tabs and a pullup footer.
I have just tried on an Android device with the keyboard plugin. I placed input fields both on the content area and inside the footer. It seemed fine to me. Keep in mind the keyboard will shrink the content area and cause the tab bar and pullup footer to be placed above the keyboard. I haven't tried this on iOS. Maybe you can comment?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants