Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS improvement for primary icon #99

Open
ThomDietrich opened this issue Sep 28, 2022 · 4 comments
Open

CSS improvement for primary icon #99

ThomDietrich opened this issue Sep 28, 2022 · 4 comments

Comments

@ThomDietrich
Copy link

Hey guys.
I am by no means a CSS expert, hence why I'm posting this as an issue.

image

As you can see, the left icon does not align with the icons and temperatures on the right. Not sure whether this ought to be corrected on the left or the right.

This change seems to fix it:

.ctl-wrap {
  margin-top: auto;
}
@regevbr
Copy link
Collaborator

regevbr commented Sep 28, 2022

need to mention that this happens when hiding the secondary info

@ThomDietrich
Copy link
Author

ThomDietrich commented Sep 28, 2022

But does it?

image

Ruling out the icon used:

image

@regevbr
Copy link
Collaborator

regevbr commented Sep 28, 2022

Oh my bad

@ThomDietrich
Copy link
Author

ThomDietrich commented Sep 28, 2022

However, we should extend the issue to also improve the alignment of the two lines of text, which are currently not centered to the orange box. (Irrespective of #100 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants