Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port GrimoireLab to Open Distro #219

Closed
GeorgLink opened this issue Oct 11, 2019 · 17 comments
Closed

Port GrimoireLab to Open Distro #219

GeorgLink opened this issue Oct 11, 2019 · 17 comments

Comments

@GeorgLink
Copy link
Member

This issue is an idea for the Open Distro Hack Day at All Things Open on October 14.

GrimoireLab currently works with Elasticsearch.
The idea is to:

  1. deploy GrimoireLab with Open Distro for Elasticsearch, matching the same version of Elasticsearch
  2. port GrimoireLab to the latest version of Open Distro.
@valeriocos
Copy link
Member

AFAIK porting grimoirelab to open distro is part of the roadmap, but doing it in 3 days sounds a bit difficult :)

The main reasons of being unable to do this task in the short-term are:

  • Migrating all current data to the latest open distro version (and make sure that the data is correct).
  • Handle breaking changes between the current ES version used in GrimoireLab and the target one.

@sduenas please share your thoughts

@GeorgLink
Copy link
Member Author

part of the roadmap

That's good to know. I had searched the issues but didn't see anything.

Anyways, it may be more challenging for a one-day project. Any suggestions on smaller steps that can move us in the right direction and earn an easy win for the Hack Day participants?

@valeriocos
Copy link
Member

chaoss/grimoirelab-sirmordred#330
The corresponding internal ticket is in the backlog of the roadmap kanban.

I'll think about suggestions and let you know.

@valeriocos
Copy link
Member

An idea could be to:

  • a. have a docker compose with OD and Kibana
  • b. install Perceval
  • c1. execute Perceval against Git/GitHub/GitLab/Meetup/... repo
  • c2. take the JSON documents returned and save them to OD
  • d. create visualizations via Kibana

Points c1 and c2 would require the participants to write a Python script combining Perceval and ElasticSearch (or requests) library. In this way, they will use part of GrimoireLab and play with OD. WDYT?

@sduenas
Copy link
Member

sduenas commented Oct 12, 2019

What do you mean to port GrimoireLab to OpenDistro? GrimoireLab (especifically Mordred and ELK) only need a ElastickSearch and Kibana endpoints to work. As far as I know, that's what OpenDistro provides.

So configuring SirModred would be more than enough if you have running OpenDistro. Am I missing something?

@valeriocos
Copy link
Member

You're right @sduenas, however there are some considerations to take into account.

@sduenas
Copy link
Member

sduenas commented Oct 12, 2019

@dlumbrer was able to use GrimoireLab with OpenDistro. Probably he can give us more info.

@valeriocos
Copy link
Member

that's true, I forgot about the evaluation of @dlumbrer

@valeriocos
Copy link
Member

While waiting for @dlumbrer feedback, we got the one from @jjmerchante (please, feel free to join the discussion) who is using OD 0.9.0 for Cauldron. The platform seems to work fine at least for the following data sources: git, gitlab, github, meetup. He also reported that there are some minor changes to apply on the docker-compose.

For the next time @GeorgLink, it would be great to start this kind of discussions with more than 3 days in advance to be able to help you.

@jsmanrique
Copy link
Contributor

FYI, there is already possible to use core GrimoireLab with Open Distro for Elasticsearch (ODFE), but not with the latest version of ODFE (check chaoss/grimoirelab-sirmordred#330 and chaoss/grimoirelab-sirmordred#318). But if you wanna play I've created a custom docker-compose.yml file for testing ODFE 0.9.0:

https://gitlab.com/jsmanrique/grimoirelab-for-demos#bonus

The main differences with current GrimoireLab full deployment are:

  • that everything related with panels is deactivated in the custom setp.cfg I've created, so:
    • There is no default Kibana index pattern (you need to configure it manually in Kibana)
    • There is no navigation menu to access to the dashboards.
    • There are pre-loaded dashboards / panels
  • @dlumbrer plugins are not pre-loaded, so you would need to load them manually

Having said that, perhaps a good project for the hackathon would be:

  • update GrimoireLab to use latest version of ODFE, with the minimum requirement of updating GrimoireLab data mappings.
  • test and demo it with current GrimoireLab for demos or analytics demo.

But, IMHO, I am not sure if that should be something for a GrimoireLab hackathon instead of a ODFE hackathon, but I would let the organizers to decide.

Additional extra "outcomes" could be:

And perhaps things could be easier if chaoss/grimoirelab-sirmordred#84 gets solved sometime :-)

@jsmanrique
Copy link
Contributor

@dlumbrer was able to use GrimoireLab with OpenDistro. Probably he can give us more info.

He only tested some data dumps with mini mordred and ODFE 0.9.0. A couple of weeks ago, we tested with the latest ODFE and it was when we realized about the mapping issues mentioned before.

@dlumbrer
Copy link
Contributor

dlumbrer commented Oct 14, 2019

@dlumbrer was able to use GrimoireLab with OpenDistro. Probably he can give us more info.

He only tested some data dumps with mini mordred and ODFE 0.9.0. A couple of weeks ago, we tested with the latest ODFE and it was when we realized about the mapping issues mentioned before.

That's right, I want to add that we can modify the Kibana provided in Open Distro in order to have our Kibiter (that includes menu, colors and plugins installation), because the docker images are available and we can add the features on it.

@GeorgLink
Copy link
Member Author

For the next time @GeorgLink, it would be great to start this kind of discussions with more than 3 days in advance to be able to help you.

Sorry about the short notice. I strive to give everyone as much time as possible. I posted the issue as soon as I knew that we needed an issue. With the short time left, I was not expecting the level of detail that everyone provided, but I very much appreciate all of the input here. I think it is great that we have this much information that will be valuable to hackathon participants.

@valeriocos
Copy link
Member

no worries @GeorgLink :) good luck with the hackathon!

@GeorgLink
Copy link
Member Author

Thank you @valeriocos @GeorgLink @jsmanrique @dlumbrer for the discussion and pointing out the potential pitfalls and steps required for resolving this issue. This information was very helpful for me when I was asked about this issue during the Hackathon. Due to the complexity of this issue and the limited time during the Hack day, no one went for this issue. However, someone started and got fairly far with porting the radio chart to open distro for kibana. 👍

@valeriocos
Copy link
Member

An initial support for ODFE is ready for review:

Note that uploading panels to Kibana is currently not supported for ODFE

Please @sduenas have a look

@sduenas
Copy link
Member

sduenas commented Jun 30, 2020

GrimoireLab is compatible with ODFE 0.9.0 now.

Closing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants