Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected KO countdown outside the ring #113

Open
AndrejOrsula opened this issue Sep 26, 2023 · 1 comment
Open

Unexpected KO countdown outside the ring #113

AndrejOrsula opened this issue Sep 26, 2023 · 1 comment

Comments

@AndrejOrsula
Copy link
Contributor

Hello,

During one of the games earlier today, I noticed a "potential" issue with the knockout countdown algorithm when one of the players fell off the ring.
The game was evaluated during CI run #7245, and the full replay of the game is attached below (the important bit starts from 1:45).

wrestling_potential_issue_with_ko_countdown_algo.mp4

I was confused at first, but I believe the KO countdown for the player outside the ring was not continuously triggered because the position of their head was higher compared to the other player (Z coordinate). This change was introduced via #96 according to the following description in #95.

Improve the KO countdown algorithm: when a robot gets below the height threshold, start the countdown for this robot. However, if the other robot gets below the first one, then stop the countdown for the first robot and start it for the second one, etc.

It is probably too late to discuss/change the knockout counter algorithm for the current edition, but I just wanted to bring it to your attention for future reference. :)

@omichel
Copy link
Member

omichel commented Sep 26, 2023

True. We will try to fix that later on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants