Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CCA Diversity] better integrations test coverage #104

Open
nickbalestra opened this issue Apr 10, 2017 · 4 comments
Open

[CCA Diversity] better integrations test coverage #104

nickbalestra opened this issue Apr 10, 2017 · 4 comments

Comments

@nickbalestra
Copy link
Collaborator

We could now rely on installScripts.js to pass prompt answers and test multiple combinations by snapshotting results, or simply add similar tests to the cycle-script repo as well. This make #101 it a good point for keeping questions also within the CLI as will make testing this easier due to init() being able to accept those params.

@nickbalestra
Copy link
Collaborator Author

Now that we got the typescript files in we should probably add tests as next thing. What you think @jvanbruegge ?

@jvanbruegge
Copy link
Collaborator

yeah, integration tests would be good
however i would wait with #94 until #103

@nickbalestra
Copy link
Collaborator Author

nickbalestra commented Apr 10, 2017

Yes, perhaps after #103 but before we move forward after that (#94 goes with #93 i guess).

@jvanbruegge
Copy link
Collaborator

jvanbruegge commented Apr 10, 2017

the integration tests can be written before #103
Just not the tests for the template

perjerz pushed a commit to perjerz/create-cycle-app that referenced this issue Nov 12, 2018
Add cycle-selection-driver to drivers section
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants