Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript & Javascript prompt for cycle-scripts #108

Closed
nickbalestra opened this issue Apr 17, 2017 · 2 comments
Closed

Typescript & Javascript prompt for cycle-scripts #108

nickbalestra opened this issue Apr 17, 2017 · 2 comments

Comments

@nickbalestra
Copy link
Collaborator

This issue to discuss if, when, and how, to bring TS and JS together within CCA & cycle-scripts.

Issues that emerged from this:

@jvanbruegge
Copy link
Collaborator

jvanbruegge commented Apr 17, 2017

I think the way it is in #105 is quite good. I don't see big tradeoffs. We use native ES6 templates that allow us to reduce code doublication and therefore a source of possible mistakes. Webpack blocks makes this aproach feasable.
I would however move from the custom build/start scripts to just spawing the webpack cli, as this allows us to completely remove traces of the flavor on eject and not litter the working directory with scripts. (we could add this later on, as this doesnt matter pre-eject)
I think the init question should be part of the flavor, not part of CCA, because they are only used by the flavor.

@jvanbruegge
Copy link
Collaborator

Done in V4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants