-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jsxFactory should be export from this package, not from @cycle/react-dom #8
Comments
Hmm, good point! PRs welcomed (hopefully 2 PRs, one to remove JSX pragma from |
Okay, I'll submit a pull request in a few days! (Luckily, now it's on holidays in Japan 😊) BTW, instead of removing it from |
Even better idea! |
Fixes cyclejs#8 Implementation of `jsxFactory` is just a copy and paste from @sliptype's pull request (cyclejs/react-dom#3). Test cases have been rewritten in a DOM-free way (using enzyme).
Fixes cyclejs#8 Implementation of `jsxFactory` is just a copy and paste from @sliptype's pull request (cyclejs/react-dom#3). Test cases have been rewritten in a DOM-free way (using enzyme).
Fixes cyclejs#8 Implementation of `jsxFactory` is just a copy and paste from @sliptype's pull request (cyclejs/react-dom#3). Test cases have been rewritten in a DOM-free way (using enzyme).
Fixes cyclejs#8 Implementation of `jsxFactory` is just a copy and paste from @sliptype's pull request (cyclejs/react-dom#3). Test cases have been rewritten in a DOM-free way (using enzyme).
Problem
jsxFactory
should be export from@cycle/react
, not from@cycle/react-dom
.Why
There are many DOM-free React projects in the world such as Ink and Adapt.
Library versions
@cycle/react
@cycle/react-dom
The text was updated successfully, but these errors were encountered: