Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wishlist for improving testing/demoing #714

Open
2 of 4 tasks
maelle opened this issue Sep 25, 2023 · 6 comments
Open
2 of 4 tasks

Wishlist for improving testing/demoing #714

maelle opened this issue Sep 25, 2023 · 6 comments

Comments

@maelle
Copy link
Member

maelle commented Sep 25, 2023

@krlmlr

@maelle
Copy link
Member Author

maelle commented Oct 2, 2023

Notes on pre_release() testing

For create_pull_request(), use test switch or mocking.
use rlang interactive option to circumvent edit_file()

@krlmlr
Copy link
Contributor

krlmlr commented Oct 2, 2023

Let's start with a simple R script that goes through the entire release process. It should work offline, for speed, mocking away anything that might need connectivity.

@krlmlr
Copy link
Contributor

krlmlr commented Oct 23, 2023

Seems good enough now?

@maelle
Copy link
Member Author

maelle commented Nov 6, 2023

yes but we don't have "mock the CRAN release somehow, for testing and also for demoing." in particular

@krlmlr
Copy link
Contributor

krlmlr commented Nov 6, 2023

We're mocking it away, we can call release() in the tests without failing. What else do we need to do?

@maelle
Copy link
Member Author

maelle commented Nov 6, 2023

right, we're avoiding more than mocking, but i guess mocking wouldn't bring much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants