Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues of the kotlin compiler are blamed at detekt plugin #271

Open
arturbosch opened this issue Aug 22, 2022 · 3 comments
Open

Issues of the kotlin compiler are blamed at detekt plugin #271

arturbosch opened this issue Aug 22, 2022 · 3 comments

Comments

@arturbosch
Copy link
Member

We get a large amount of bug reports regarding issues coming from the kotlin compiler but are blamed at the detekt plugin.
One might notice no stacktrace which mentioned any of detekt's known packages.

The issue might be that detekt bundles API's which is clearly shipped by Intellij and the Kotlin plugin itself.
This is to the nature that the Kotlin compiler (which detekt uses the embedded version) bundles itself some of IntelliJ apis.

Compatibility warnings (1): 
    #Plugin bundles IDE packages
        The plugin distribution bundles IDE packages 'org.jetbrains.org.objectweb.asm.signature', 'org.jetbrains.org.objectweb.asm.commons', 'org.jetbrains.org.objectweb.asm', 'org.jetbrains.org.objectweb.asm.util', 'org.jetbrains.org.objectweb', 'org.jetbrains.org.objectweb.asm.tree.analysis', 'org.jetbrains.concurrency', 'org.jetbrains.org.objectweb.asm.tree', 'org.jetbrains.org'. Bundling IDE packages is considered bad practice and may lead to sophisticated compatibility problems. Consider excluding these IDE packages from the plugin distribution. If your plugin depends on classes of an IDE bundled plugin, explicitly specify dependency on that plugin instead of bundling it. 

The bug reporting logic of IntelliJ might consider exception thrown from above packages are caused by detekt.

@nils-a
Copy link

nils-a commented Aug 26, 2022

@arturbosch I had this only once and never again, but if there's anything I can test/try or help with, don't hesitate to reach out.

This was referenced Sep 18, 2022
@arturbosch
Copy link
Member Author

I have the impression that the Kotlin compiler reports less from 2023.1+.

@kenyee
Copy link

kenyee commented Jun 4, 2024

We're seeing this in our IDEA/AS logs as well. Probably worth mentioning in the repo Readme since it seems to be happening to everyone...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants