Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement BoundedStorable for more data types #92

Open
0kenx opened this issue Jun 21, 2023 · 2 comments
Open

Implement BoundedStorable for more data types #92

0kenx opened this issue Jun 21, 2023 · 2 comments

Comments

@0kenx
Copy link

0kenx commented Jun 21, 2023

 help: the following other types implement trait `BoundedStorable`:
              ()
              (A, B)

Would be nice to implement this for (A, B, C...) in accordance with candid.

@0kenx
Copy link
Author

0kenx commented Jun 21, 2023

Also for Vec<T> and [T; N], where T is BoundedStorable and N: usize

@ielashi
Copy link
Contributor

ielashi commented Jun 23, 2023

Would be nice to implement this for (A, B, C...) in accordance with candid.

I agree. We don't rely on candid for the (A, B) encoding though and neither should we for (A, B, C). If you have the cycles maybe this is something you'd like to contribute? :)

Also for Vec and [T; N], where T is BoundedStorable and N: usize

Vec<T> is not bounded, so we cannot implement BoundedStorable for it. We already have a BoundedStorable implementation for [T; N] (see here)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants