Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] Fix Cleanup code on CollectionView #26134

Open
PureWeen opened this issue Nov 26, 2024 · 0 comments · Fixed by #26138
Open

[iOS] Fix Cleanup code on CollectionView #26134

PureWeen opened this issue Nov 26, 2024 · 0 comments · Fixed by #26138
Labels
p/0 Work that we can't release without s/triaged Issue has been reviewed
Milestone
.NET 9 SR2

Comments

@PureWeen
Copy link
Member

PureWeen commented Nov 26, 2024 •
edited
Loading

Description

  1. The following code doesn't unsubscribe if you set a new footer/header
    Image

  2. None of the dispose code inside StructuredItemsViewController ever runs. We need to move all the logic that cleanups the control into a "disconnect" method and then call the "disconnect" method from DIsconnectHandler. We don't want to actually call dispose on anything
@dotnet-policy-service dotnet-policy-service bot added the s/triaged Issue has been reviewed label Nov 26, 2024
@PureWeen PureWeen changed the title [iOS] Remove subscriptions to LayoutChanged inside StructuredItemsViewController [iOS] Fix Cleanup code on CollectionView Nov 26, 2024
@PureWeen PureWeen mentioned this issue Nov 27, 2024
Merged
@PureWeen PureWeen added this to the .NET 9 SR2 milestone Nov 27, 2024
@PureWeen PureWeen moved this from Todo to In Progress in MAUI SDK Ongoing Nov 27, 2024
@PureWeen PureWeen added the p/0 Work that we can't release without label Nov 27, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in MAUI SDK Ongoing Nov 27, 2024
@PureWeen PureWeen reopened this Nov 27, 2024
@github-project-automation github-project-automation bot moved this from Done to In Progress in MAUI SDK Ongoing Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p/0 Work that we can't release without s/triaged Issue has been reviewed
Projects
MAUI SDK Ongoing
Status: In Progress
Milestone
.NET 9 SR2
Development

Successfully merging a pull request may close this issue.

Make sure to unsubscribe from LayoutChanged on CV dotnet/maui
1 participant
@PureWeen