Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure to unsubscribe from LayoutChanged on CV #26138

Merged
merged 2 commits into from
Nov 27, 2024
Merged

Make sure to unsubscribe from LayoutChanged on CV #26138

merged 2 commits into from
Nov 27, 2024

Conversation

PureWeen
Copy link
Member

@PureWeen PureWeen commented Nov 27, 2024

Description of Change

The following PR isn't unsubscribing from the LayoutChanged event on the CollectionView when setting a new footer/header and when disconnecting the handler from the CollectionView.

Issues Fixed

Fixes #26134

@PureWeen PureWeen requested a review from a team as a code owner November 27, 2024 00:11
@PureWeen PureWeen added this to the .NET 9 SR2 milestone Nov 27, 2024
Redth
Redth previously approved these changes Nov 27, 2024
@PureWeen
Copy link
Member Author

/backport to release/9.0.1xx-sr1

Copy link
Contributor

Started backporting to release/9.0.1xx-sr1: https://github.com/dotnet/maui/actions/runs/12041857653

@PureWeen PureWeen modified the milestones: .NET 9 SR2, .NET 9 SR1.2 Nov 27, 2024
@PureWeen
Copy link
Member Author

  • failing tests are unrelated

@PureWeen PureWeen merged commit d91bf0a into main Nov 27, 2024
100 of 104 checks passed
@PureWeen PureWeen deleted the fix_26134 branch November 27, 2024 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[iOS] Fix Cleanup code on CollectionView
2 participants