Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When attacking, only the first two sounds of each weapon type are used, not the third #699

Open
avengah opened this issue Sep 23, 2022 · 1 comment

Comments

@avengah
Copy link

avengah commented Sep 23, 2022

var r = Math.floor(Math.random() * 2) + 1;

The problem here is that this expression can only produce 1 or 2, not 3. It should be changed to * 3 instead of * 2, to use all three variations of each weapon sound.

avengah added a commit to avengah/adarkroom that referenced this issue Sep 23, 2022
Just a simple fix so that it can play all three of each type of weapon sound. As mentioned in Issue doublespeakgames#699.
@avengah
Copy link
Author

avengah commented Apr 4, 2024

The line in question appears twice in events.js, once for the player's attack and once for the enemy's attack, which I missed last time. Still, it hasn't been fixed yet.

avengah added a commit to avengah/adarkroom that referenced this issue Apr 4, 2024
Make it so that all three sounds can play for each weapon type instead of just the first two.
NoReligion added a commit to NoReligion/adarkroom that referenced this issue Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant