Add RG_GPIO_LED_ACTIVE_LOW option #149
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On the Fri3d Camp 2024 badge, the RG_GPIO_LED is active low, meaning it is on when the output is 0/low and off when the output is 3V3/high. Therefore, we need a way to invert the regular RG_GPIO_LED. At first I used RG_GPIO_LED_INVERT but that is less descriptive than RG_GPIO_LED_ACTIVE_LOW.
|
I've recently been working on improving LED, to support colors and intensity and flashing patterns. But it's not ready so for now I'm okay with merging your PR. Though it conflicts with changes I've pushed a few days. I got rid of |
|
Okay, I merged the dev branch and modified it as I think it should be, although I was a bit confused by the RGB functionality. Hope it's good like this? |
ducalex
force-pushed
the
dev
branch
12 times, most recently
from
8874d4b
to
3d3cbb0
Compare
ducalex
force-pushed
the
dev
branch
4 times, most recently
from
85ebb0a
to
c1ed05a
Compare
ducalex
force-pushed
the
dev
branch
4 times, most recently
from
c696780
to
2e778fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the Fri3d Camp 2024 badge, the RG_GPIO_LED is active low, meaning it is on when the output is 0/low and off when the output is 3V3/high.
Therefore, we need a way to invert the regular RG_GPIO_LED.
At first I used RG_GPIO_LED_INVERT but that is less descriptive than RG_GPIO_LED_ACTIVE_LOW.