Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

with default snapshot distance, hitting crash complaining compact_lsn exceeding cur_max_lsn #446

Open
yamingk opened this issue Jun 13, 2024 · 0 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@yamingk
Copy link
Contributor

yamingk commented Jun 13, 2024

With default snapshot distance, which is currently 2000, below command line will hit crash complaining compact_lsn passed down from nuraft server that is exceeding cur_max_lsn

./bin/test_raft_repl_dev --gtest_filter=*Snapshot_and_Compact* --num_io=999999 --override_config nuraft_mesg_config.mesg_factory_config.data_request_deadline_secs:120 --config_path ./config --dev_size_mb=8192 2>&1 | tee log

Assert hit here at line: 287

282 bool HomeRaftLogStore::compact(ulong compact_lsn) {
283     auto cur_max_lsn = m_log_store->get_contiguous_issued_seq_num(m_last_durable_lsn);
284     if (cur_max_lsn < to_store_lsn(compact_lsn)) {
285         // release this assert if for some use case, we should tolorant this case;
286         // for now, don't expect this case to happen.
287         RELEASE_ASSERT(false, "compact_lsn={} is beyond the current max_lsn={}", compact_lsn, cur_max_lsn);
@yamingk yamingk added this to the MileStone4.3 milestone Jun 13, 2024
@yamingk yamingk added the bug Something isn't working label Jun 13, 2024
@sanebay sanebay self-assigned this Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants