Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checksum for pushdata/fetchdata #581

Open
Besroy opened this issue Nov 6, 2024 · 1 comment
Open

Add checksum for pushdata/fetchdata #581

Besroy opened this issue Nov 6, 2024 · 1 comment
Assignees

Comments

@Besroy
Copy link
Contributor

Besroy commented Nov 6, 2024

From SM-long-running-test side, we encountered failures during the data read_verify process on two separate occasions:
Hash Mismatch: The issue occurred once where one follower experienced a hash mismatch.
Invalid Header: Another instance where a different follower encountered an invalid header.
Additional Details: For more comprehensive information and context regarding these failures, please refer to the documentation provided in the following link: Google Docs

@xiaoxichen xiaoxichen changed the title Data Mismatch in read verify Add checksum for pushdata/fetchdata Nov 25, 2024
@xiaoxichen
Copy link
Collaborator

quick fix , add length check in #586

Team discussed and decide to add checksum into the pushdata/fetchdata.
better to make it a configuration so that we can quantify the overhead in performance testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants