Dealing with unhandled promise rejections in Kibana nodejs process

[mshustov]

Node.js starting from v16 terminate a node process in the event of an unhandled promise rejection. Kibana in the versions <7.16 log a warning about a promise rejection not being properly handled. Starting from Kibana v7.16+, it leads to the Kibana server crashing.
If we do not begin to prevent this problem, we can face a situation where changing the Kibana code will increase the instability of the Kibana server.

Liniting

The best thing we can do is to catch the problem as early as possible in the development process to eliminate dangerous patterns on the stage of writing the code.
@typescript-eslint/no-floating-promises rule enforces error handling for created promises

This rule forbids the usage of Promise-like values in statements without handling their errors appropriately. Unhandled promises can cause several issues, such as improperly sequenced operations, ignored Promise rejections and more. Valid ways of handling a Promise-valued statement include awaiting, returning, and either calling .then() with two arguments or .catch() with one argument.

To use this rule, it is necessary to provide a plugin-specific tsconfig.json file. Starting from #114184, plugins can declare plugin-specific linting configuration. So we can enable the rule gradually in the repository.

Testing

There were several complaints that the Kibana server crashed on CI due to a network error:

• in Monitoring plugin

  kibana/x-pack/plugins/monitoring/server/static_globals.ts

  Line 77 in 641b622

  await mbSafeQuery(async () => {

• in SecuritySolution

  kibana/x-pack/plugins/security_solution/server/lib/detection_engine/signals/single_search_after.ts

  Line 90 in 641b622

  exc.message.includes('No mapping found for [@timestamp] in order to sort on') ||

  (Bulk Indexing of signals failed: TypeError: exc.message.includes is not a function name:...)

It's hard to ensure Kibana plugins test all the possible "un-happy paths" during unit testing.
Instead of relying on the developers to do the right thing, we can add elements of chaos testing to a sub-set of functional tests to make sure Kibana is stable and resilient in the case of intermittent network problems.

Monitoring

Right now, we don't have any particular numbers on how often it leads to the Kibana server crash in the production. We are only aware of cases when users create a bug report in the repo or reach out to support to complain about runtime crashes.
Enabling APM on Cloud should help us to start monitoring the number of runtime crashes. @lizozom is it on your radar after we enable monitoring on Cloud in #117492?

[elasticmachine]

Pinging @elastic/kibana-operations (Team:Operations)

[elasticmachine]

Pinging @elastic/kibana-core (Team:Core)

[kobelb]

Doesn't the following prevent unhandled promise rejections from crashing Kibana in 7.16+ https://github.com/elastic/kibana/blob/main/config/node.options#L9?

[mshustov]

@kobelb I missed that we run Kibana with this flag.
It makes the problem less critical then. However, an unhandled promise rejection is a sign of a bug in the Kibana code. Which we shouldn't silently ignore.

[Samwiqs]

I would be doing it at south african social grants srd r370 to check if they can change phone number for sassa srd r350https://sassacheck.org/sassa-change-phone-number-for-srd-r350-grant/

[kobelb]

However, an unhandled promise rejection is a sign of a big in the Kibana code. Which we shouldn't silently ignore.

Completely agree. Using @typescript-eslint/no-floating-promises as you've described to eliminate these logic bugs makes total sense to me.

[pgayvallet]

Doesn't the following prevent unhandled promise rejections from crashing Kibana in 7.16+

Hum, are we using this only in production?

When trying to start Kibana and ES locally on main, and then stopping ES:

[2021-11-18T10:49:49.720+01:00][WARN ][plugins.monitoring.monitoring.kibana-monitoring] Unable to bulk upload the stats payload to the local cluster
Unhandled Promise rejection detected:

ConnectionError: connect ECONNREFUSED 127.0.0.1:9200

Terminating process...
server crashed  with status code 1

[rudolf]

When we considered whether to crash on unhandled promise rejections with the Node v16 upgrade I created the following dashboard which gives us a good enough metric in my opinion:
https://overview.elastic-cloud.com/app/dashboards#/view/cf546190-1b9a-11ec-b8ee-754395ac06ab?_g=(filters%3A!()%2CrefreshInterval%3A(pause%3A!t%2Cvalue%3A0)%2Ctime%3A(from%3Anow-1w%2Cto%3Anow))

Also encouraging to see we're already moving in the right direction it seems...

[jbudz]

Doesn't the following prevent unhandled promise rejections from crashing Kibana in 7.16+

Hum, are we using this only in production?

When trying to start Kibana and ES locally on main, and then stopping ES:

[2021-11-18T10:49:49.720+01:00][WARN ][plugins.monitoring.monitoring.kibana-monitoring] Unable to bulk upload the stats payload to the local cluster
Unhandled Promise rejection detected:

ConnectionError: connect ECONNREFUSED 127.0.0.1:9200

Terminating process...
server crashed  with status code 1

Yes - node.options is interpreted by bin/kibana.

[tylersmalley]

Related: we're prioritizing https://github.com/elastic/kibana/issues/117934 so we can lint for unhandled promises.

[tylersmalley]

Converting this to a discussion since there is no concrete action item here and doesn't need to be tracked as an incomplete task. Happy to move back if you disagree.

[afharo]

#181456 might finally fix this 🎉