Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FTR Tests] Remove unnescessary admin logins #201769

Conversation

mohamedhamed-ahmed
Copy link
Contributor

@mohamedhamed-ahmed mohamedhamed-ahmed commented Nov 26, 2024

closes #196599

@mohamedhamed-ahmed mohamedhamed-ahmed added release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Nov 26, 2024
@elastic elastic deleted a comment from elasticmachine Nov 26, 2024
@mohamedhamed-ahmed mohamedhamed-ahmed marked this pull request as ready for review November 27, 2024 10:34
@mohamedhamed-ahmed mohamedhamed-ahmed requested a review from a team as a code owner November 27, 2024 10:34
@mohamedhamed-ahmed mohamedhamed-ahmed added the Team:obs-ux-logs Observability Logs User Experience Team label Nov 27, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs)

@mohamedhamed-ahmed mohamedhamed-ahmed changed the title remove unnescessary admin logins [FTR Tests] Remove unnescessary admin logins Nov 27, 2024
@mohamedhamed-ahmed
Copy link
Contributor Author

/ci

Copy link
Contributor

@tonyghiani tonyghiani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you run a flaky test suite on this maybe? https://ci-stats.kibana.dev/trigger_flaky_test_runner/

@mohamedhamed-ahmed
Copy link
Contributor Author

LGTM, can you run a flaky test suite on this maybe? https://ci-stats.kibana.dev/trigger_flaky_test_runner/

yes just did, seems like pipelines are stuck somehow

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#7509

[❌] x-pack/test_serverless/functional/test_suites/observability/config.ts: 25/50 tests passed.

see run history

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #11 / StepSelectHosts should display create form when no agent policies

Metrics [docs]

✅ unchanged

History

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#7521

[✅] x-pack/test_serverless/functional/test_suites/observability/config.ts: 50/50 tests passed.

see run history

@mohamedhamed-ahmed mohamedhamed-ahmed merged commit bcbaef3 into elastic:main Nov 28, 2024
8 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12064478212

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 28, 2024
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Nov 28, 2024
# Backport

This will backport the following commits from `main` to `8.x`:
- [[FTR Tests] Remove unnescessary admin logins
(#201769)](#201769)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"mohamedhamed-ahmed","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-28T07:37:35Z","message":"[FTR
Tests] Remove unnescessary admin logins (#201769)\n\ncloses
https://github.com/elastic/kibana/issues/196599","sha":"bcbaef3685a7dd45027f462c56a1dee26467ae1e","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","Team:obs-ux-logs"],"title":"[FTR
Tests] Remove unnescessary admin
logins","number":201769,"url":"https://github.com/elastic/kibana/pull/201769","mergeCommit":{"message":"[FTR
Tests] Remove unnescessary admin logins (#201769)\n\ncloses
https://github.com/elastic/kibana/issues/196599","sha":"bcbaef3685a7dd45027f462c56a1dee26467ae1e"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201769","number":201769,"mergeCommit":{"message":"[FTR
Tests] Remove unnescessary admin logins (#201769)\n\ncloses
https://github.com/elastic/kibana/issues/196599","sha":"bcbaef3685a7dd45027f462c56a1dee26467ae1e"}}]}]
BACKPORT-->

Co-authored-by: mohamedhamed-ahmed <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-logs Observability Logs User Experience Team v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Dataset Quality] Enhance Serverless FTR Tests
4 participants