Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens][Embeddable] Expose the parentApi via the embeddable API #202006

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dej611
Copy link
Contributor

@dej611 dej611 commented Nov 27, 2024

Summary

Fixes #199736

This PR exposes the parentApi when it satisfy the PresentationContainer type: this allows api consumers (i.e. dashboard actions) to access the full container context for complex evaluation of an action (i.e. are there other panels? what types are they made of? etc...).

I've limited it to PresentationContainer as this was the original intent of the feature request (and avoids type casting). If it needs to be extended more another follow up can be done.

@dej611 dej611 added Team:Visualizations Visualization editors, elastic-charts and infrastructure release_note:skip Skip the PR/issue when compiling release notes Feature:Lens backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Nov 27, 2024
@dej611 dej611 marked this pull request as ready for review November 27, 2024 16:43
@dej611 dej611 requested a review from a team as a code owner November 27, 2024 16:43
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.5MB 1.5MB +58.0B

History

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Lens][Embeddable] Expose parentApi on Lens API
2 participants