Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataDiscovery] EUI Visual Refresh integration and QA #202041

Open
9 tasks
kertal opened this issue Nov 27, 2024 · 1 comment
Open
9 tasks

[DataDiscovery] EUI Visual Refresh integration and QA #202041

kertal opened this issue Nov 27, 2024 · 1 comment
Assignees
Labels
Feature:Discover Discover Application impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.

Comments

@kertal
Copy link
Member

kertal commented Nov 27, 2024

This is a meta issue to track the progress of the upgrader to Borealis on Data Discover side, a sub issue of #199715, which provides more context and details

Definition of Done

Things marked as Required must be completed. Everything else we would really like teams to give their best effort to resolve, but are ultimately non-blocking.

More detail on each of these steps is noted in detail below.

  • (Required) All usages of "success" colors have been updated to "accentSecondary" and "textAccentSecondary" as needed
  • (Required) All usages of "successText" colors have been updated to "textAccentSecondary" as needed.
  • (Required) All references to renamed tokens have been updated to use the new token name.
  • (Required) All usage of color palette tokens and functions now pull from the theme, and correctly update to use new colors when the theme changes from Borealis to Amsterdam and vice versa.
  • (Required) The person assigned to "Design QA" has reviewed the UI with the new changes and is ready to ship.
  • All usages of vis colors for non-visulalization usage have been removed in favor of other EUI color tokens, where possible.
  • All "Custom colors" have been replaced with EUI color tokens.
  • All usages of color functions have been removed in favor of color tokens, where possible.
  • All usages of JSON tokens have been removed in favor of color tokens, where possible.
@botelastic botelastic bot added the needs-team Issues missing a team label label Nov 27, 2024
@kertal kertal added Feature:Discover Discover Application Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. and removed needs-team Issues missing a team label labels Nov 27, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@kertal kertal changed the title [Eui][DataDiscovery] Borealis theme checks and issues [DataDiscovery] EUI Visual Refresh integration and QA Nov 27, 2024
@kertal kertal added the impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. label Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Discover Discover Application impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Projects
None yet
Development

No branches or pull requests

3 participants