New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Base elements - now and the future #741

Open

ljelinkova opened this issue Jun 6, 2018 · 1 comment

Labels

Contributor

ljelinkova commented Jun 6, 2018

With our recent problems with dropdown I've been looking into the base elements. Those classes have been created some time ago and need reviewing.

These are some areas that may need attention

they should encapsulate all its properties
they are extending ElementFinder which makes it difficult to control what the client code does with it. We should aggregate it instead
logging - they should use support for logging
remove BaseElementArray since it is not used anywhere

@ppitonak @ldimaggi @pmacik WDYT?

ppitonak added the E2E-test label

Collaborator

ppitonak commented Jun 28, 2018

Logging partially solved by #840

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment